Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mc-scripts): regression when updating webpack-dev-server to 4.0.0-beta.3 #2210

Merged
merged 1 commit into from
May 11, 2021

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented May 11, 2021

Caused by #2199

This slipped through in the latest dependency upgrade

image

causing local dev to not start:

image

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2021

🦋 Changeset detected

Latest commit: 02ed088

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools-frontend/mc-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/2ArQ4ZfPVk94xP5yC9j1p2kLgHGj
✅ Preview: https://merchant-cente-git-nm-fix-webpack-dev-server-40-beta3-co-4857f3.vercel.app

@emmenko emmenko requested a review from tdeekens May 11, 2021 21:28
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Sneaky.

@emmenko emmenko enabled auto-merge (squash) May 11, 2021 21:30
@tdeekens
Copy link
Contributor

Interesting use case for a E2E test. Instead of building and serving just using the webpack-dev-server maybe 🤔.

@emmenko emmenko merged commit 0090f45 into main May 11, 2021
@emmenko emmenko deleted the nm-fix-webpack-dev-server-4.0-beta.3 branch May 11, 2021 21:34
@ghost ghost mentioned this pull request May 11, 2021
@emmenko
Copy link
Member Author

emmenko commented May 11, 2021

Yeah I was thinking the same, although I would say testing the production bundle is more important.

Maybe we can have a step to only start the dev server? This should then prevent such regressions. We can use the "wait for" to terminate the step once localhost is available.

@tdeekens
Copy link
Contributor

Yes, that's what I thought too. Wasn't meaning to imply that we should replace the production bundle testing with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants