feat(babel-preset-mc-app): add ability to disable core-js #2261
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/7ZyXnoiwvquNdf7YkxYVknRDndD6 |
🦋 Changeset detectedLatest commit: 23e54a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -143,7 +149,7 @@ module.exports = function getBabePresetConfigForMcApp(api, opts = {}) { | |||
| { | |||
| // corejs messes with jest@27 in tests, due to some | |||
| // Promise/Date related polyfills it provides. | |||
| corejs: !isEnvTest && 3, | |||
| corejs: isEnvTest || options.disableCoreJs ? false : 3, | |||
There was a problem hiding this comment.
This would enable corejs in test env all the time regardless of the disableCoreJs option.
There was a problem hiding this comment.
You mean disable, right? If so yes, that's what @pa3 implemented prior and intended.
tdeekens
force-pushed
the
disable-core-js
branch
from
52ffa61
to
19ae413
Compare
tdeekens
force-pushed
the
disable-core-js
branch
from
d1bb3f6
to
23e54a3
Compare
ghost
mentioned this pull request
Summary
This adds the ability to explicitly disable
core-js.Description
Some environments or build targets might not require
core-js. In order to opt-out of it you can specify adisableCoreJsoption now.