-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(babel-preset-mc-app): add ability to disable core-js #2261
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/7ZyXnoiwvquNdf7YkxYVknRDndD6 |
🦋 Changeset detectedLatest commit: 23e54a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -143,7 +149,7 @@ module.exports = function getBabePresetConfigForMcApp(api, opts = {}) { | |||
{ | |||
// corejs messes with jest@27 in tests, due to some | |||
// Promise/Date related polyfills it provides. | |||
corejs: !isEnvTest && 3, | |||
corejs: isEnvTest || options.disableCoreJs ? false : 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would enable corejs
in test env all the time regardless of the disableCoreJs
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean disable, right? If so yes, that's what @pa3 implemented prior and intended.
52ffa61
to
19ae413
Compare
d1bb3f6
to
23e54a3
Compare
Summary
This adds the ability to explicitly disable
core-js
.Description
Some environments or build targets might not require
core-js
. In order to opt-out of it you can specify adisableCoreJs
option now.