Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mc-scripts): web socket config to make HMR work #2334

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Aug 5, 2021

I noticed that HMR wasn't working anymore. I changed it to be the same of what CRA uses.

@vercel
Copy link

vercel bot commented Aug 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/8m6Uo7ZvNHA8LbUnhfAcb9vYEw4c
✅ Preview: https://merchant-center-application-kit-git-nm-fix-hmr-commercetools.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2021

🦋 Changeset detected

Latest commit: 741c752

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools-frontend/mc-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmenko emmenko requested a review from pa3 August 5, 2021 13:18
@emmenko emmenko changed the title fix(mc-scripts): web socket config to make HRM work fix(mc-scripts): web socket config to make HMR work Aug 5, 2021
@emmenko emmenko merged commit 869a3b6 into main Aug 5, 2021
@emmenko emmenko deleted the nm-fix-hmr branch August 5, 2021 15:46
@ghost ghost mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants