Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nvmrc): set node version to 16.8 in nvmrc to avoid a bug in node/v8 #2356

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

ByronDWall
Copy link
Contributor

Summary

This pins the node version in .nvmrc to 16.8 for the time being in order to avoid a bug introduced in the latest version of node due to upstream changes in v8

Description

The build_lint_and_test github action in this repo started to fail with this output: Check failed: !holder_map.has_named_interceptor().

To fix this issue, this PR pins the node version to 16.8 as suggested in nodejs/node#40030

@vercel
Copy link

vercel bot commented Sep 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/7U6arFjG9KtSSMQKq6TW7qwLyXoR
✅ Preview: https://merchant-center-application-kit-git-bw-upd-5663c4-commercetools.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2021

🦋 Changeset detected

Latest commit: 158eca1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
merchant-center-application-template-starter Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/custom-applications Patch
@commercetools-website/components-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ByronDWall ByronDWall requested a review from a team September 8, 2021 15:05
@ahmehri
Copy link
Member

ahmehri commented Sep 9, 2021

@ByronDWall you need to create a changeset (see #2356 (comment)).

@vercel vercel bot temporarily deployed to Preview September 9, 2021 12:05 Inactive
@ByronDWall
Copy link
Contributor Author

@ByronDWall you need to create a changeset

@ahmehri Changeset added, thanks for reminding me

@ByronDWall ByronDWall closed this Sep 9, 2021
@ByronDWall ByronDWall reopened this Sep 9, 2021
@ByronDWall ByronDWall merged commit e34fe07 into main Sep 9, 2021
@ByronDWall ByronDWall deleted the bw-update-nvmrc-due-to-v8-bug branch September 9, 2021 12:25
@ghost ghost mentioned this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants