-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nvmrc): set node version to 16.8 in nvmrc to avoid a bug in node/v8 #2356
Conversation
…v8 that causes jest to error out
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/7U6arFjG9KtSSMQKq6TW7qwLyXoR |
🦋 Changeset detectedLatest commit: 158eca1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ByronDWall you need to create a changeset (see #2356 (comment)). |
@ahmehri Changeset added, thanks for reminding me |
Summary
This pins the node version in
.nvmrc
to16.8
for the time being in order to avoid a bug introduced in the latest version ofnode
due to upstream changes inv8
Description
The
build_lint_and_test
github action in this repo started to fail with this output:Check failed: !holder_map.has_named_interceptor().
To fix this issue, this PR pins the node version to
16.8
as suggested in nodejs/node#40030