-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(application-config): Enforce uniqueness for uriPath of the submenu links. #2567
Conversation
…row error when there is a duplicate uripath
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 5b73315 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea extending the schema with the ajv-keywords
(didn't know about it).
However, I believe it does not fully cover our requirements.
Maybe worthwhile double checking internally. I think one app alternates between the same sub menu right now using toggles. |
Hmm I double checked. I guess you are referring to product types / attribute groups. From what I understand, the main reason for using the same link with different toggles is to have different labels. We want to enforce uniqueness so I guess we would need to change the workaround. I'll check with the team responsible for that. |
Yes. It is temporary. Probably best to have a chat with them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
uriPath
of the submenu links.
uriPath
of the submenu links.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now 👌
Summary
SubmenuLinks are meant to be "unique" based on the
uriPath
An error is thrown if there are duplicate uriPath in the submenuLinks.
SHIELD-469