Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export TImageRegexContext type from @commercetools-frontend/application-shell-connectors #2653

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

kark
Copy link
Contributor

@kark kark commented Jun 23, 2022

This PR solves the issue with importing the TImageRegexContext type.

Allows to use:
import type { TImageRegexContext } from '@commercetools-frontend/application-shell-connectors';
instead of:
import type { TImageRegexContext } from '@commercetools-frontend/application-shell-connectors/dist/declarations/src/components/project-extension-image-regex/project-extension-image-regex';

Noticed while working on docs

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2022

🦋 Changeset detected

Latest commit: f51cbbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/permissions Patch
merchant-center-application-template-starter Patch
playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-fvvt1oqob-commercetools.vercel.app
https://appkit-sha-7a1e8b4199f09023615da5d7f15dba99ced30401.commercetools.vercel.app
https://appkit-pr-2653.commercetools.vercel.app

Built with commit f51cbbf.
This pull request is being automatically deployed with vercel-action

@kark kark requested a review from a team June 23, 2022 10:26
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kacper 💯

@kark kark merged commit 405aa67 into main Jun 23, 2022
@kark kark deleted the kk-export-project-extension-image-regex-type branch June 23, 2022 11:51
@ghost ghost mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants