Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n extract command in TS starter template #2677

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

CarlosCortizasCT
Copy link
Contributor

Fixes the pattern used to extract i18n messages in the extract-intl command (script in the package.json) for the Typescript starter template.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2022

⚠️ No Changeset found

Latest commit: 3f1a77a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-gr8c228mo-commercetools.vercel.app
https://appkit-sha-7f800d8e27f02ef576540532164767d37cdb5305.commercetools.vercel.app
https://appkit-pr-2677.commercetools.vercel.app

Built with commit 3f1a77a.
This pull request is being automatically deployed with vercel-action

@CarlosCortizasCT CarlosCortizasCT merged commit 533dff6 into main Jul 1, 2022
@CarlosCortizasCT CarlosCortizasCT deleted the cm-ts-template-i18n-command-fix branch July 1, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Status: ship it Triggers an merge if rules match via bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants