feat(cli): Use additional permissions with config-sync command #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5f45a61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 5a7680f. |
emmenko
reviewed
Sep 23, 2022
emmenko
reviewed
Sep 26, 2022
kark
pushed a commit
that referenced
this pull request
Nov 22, 2022
* feat(config): include additional permissions when using config-sync * refactor(cli): validate additional oathScope * refactor(cli): implement getPermissions function, update tests * refactor(cli): move getPermission function to transformer.ts * refactor(cli): add validation for additional permission name * refactor(cli): show duplicated permission name in error thrown
emmenko
pushed a commit
that referenced
this pull request
Dec 9, 2022
* feat(config): include additional permissions when using config-sync * refactor(cli): validate additional oathScope * refactor(cli): implement getPermissions function, update tests * refactor(cli): move getPermission function to transformer.ts * refactor(cli): add validation for additional permission name * refactor(cli): show duplicated permission name in error thrown
emmenko
pushed a commit
that referenced
this pull request
Dec 9, 2022
* refactor(config): define new field additionalOAuthScopes in app config * docs: improvements * docs: code review improvements * refactor(config): include additional oauth scopes in oidc flow (#2801) * refactor: make a separate PR with docs changes * feat(cli): Use additional permissions with config-sync command (#2822) * feat(config): include additional permissions when using config-sync * refactor(cli): validate additional oathScope * refactor(cli): implement getPermissions function, update tests * refactor(cli): move getPermission function to transformer.ts * refactor(cli): add validation for additional permission name * refactor(cli): show duplicated permission name in error thrown * refactor: update permission group name regex * test: fix snapshots * chore: alphabetic not alphanumeric * chore: update changeset * refactor: at least one additional oauth scope defined * test: typo Co-authored-by: Yemitan Isaiah Olurotimi <yemitanisaiah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the CLI to use additional permissions