Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readable page title document with feedback #2836

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Update readable page title document with feedback #2836

merged 4 commits into from
Oct 4, 2022

Conversation

ddouglasz
Copy link
Contributor

This is a follow up doc improvement of the remaining feedback from the Readabkle page title documentation PR (already merged)

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 999c690

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Anshuman71
Anshuman71 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Anshuman71 Anshuman71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

website/src/releases/2022-09/readable-page-title.mdx Outdated
type: feature
topics:
- Merchant Center
- UI Components
---

Custom Applications use a more readable document's title by default, which can be customized. You can read more about this feature in the [`Human-readable page title`](/development/human-readable-page-title) documentation.
Custom Applications now use a more readable, customizable document title by default. You can read more about this feature in the [`Human-readable page title`](/development/human-readable-page-title) documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Custom Applications now use a more readable, customizable document title by default. You can read more about this feature in the [`Human-readable page title`](/development/human-readable-page-title) documentation.
Custom Applications now use a more readable, customizable document title by default. You can read more about this feature in the [Human-readable page title](/development/human-readable-page-title) documentation.

Copy link
Contributor Author

@ddouglasz ddouglasz Sep 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
All updated here: f06a481

@github-actions
Copy link
Contributor

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-8u5poxteu-commercetools.vercel.app
https://appkit-sha-d4132002b1e7ac7df35a05b0cc63f0c924dcabcb.commercetools.vercel.app
https://appkit-pr-2836.commercetools.vercel.app

Built with commit 999c690.
This pull request is being automatically deployed with vercel-action

CarlosCortizasCT
CarlosCortizasCT approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@emmenko emmenko merged commit 20c0be8 into main Oct 4, 2022
@emmenko emmenko deleted the dd-update-page-title-doc-feeback branch October 4, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko approved these changes

@Anshuman71 Anshuman71 Anshuman71 approved these changes

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddouglasz @emmenko @Anshuman71 @CarlosCortizasCT