fix(mc-scripts): support prod sourcemaps when using Vite #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: efe1bb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit efe1bb0. |
tdeekens
approved these changes
Dec 23, 2022
emmenko
commented
Dec 23, 2022
| @@ -251,6 +251,7 @@ jobs: | |||
| - name: Building Playground application | |||
| run: yarn playground:build | |||
| env: | |||
| NODE_OPTIONS: '--max-old-space-size=6144' | |||
There was a problem hiding this comment.
Ok so it seems to work but we need to bump the memory.
Maybe we make it an opt-in option to generate the sourcemaps.
There was a problem hiding this comment.
I think this is a great idea 👍
emmenko
force-pushed
the
nm-vite-build-sourcemaps
branch
from
cd7632f
to
efe1bb0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now Vite (Rollup) had some issues when running production builds with the sourcemaps option activated.
You can read a bit the thread here: vitejs/vite#2433
However, yesterday an attempt to mitigate this issue was released in Rollup: vitejs/vite#2433 (comment)
The fix is opt-in via the
cacheoption of Rollup by turning it off. To quote the outcome:Let's try it out then!