Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: to use correct illustrations for maintenance pages #3100

Merged
merged 3 commits into from
May 24, 2023
Merged

refactor: to use correct illustrations for maintenance pages #3100

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c16914d
refactor: to use correct illustrations for maintenance pages
emmenko May 24, 2023
199eb36
fix: set maintenance page image height for consistency across images
emmenko May 24, 2023
2e9f9ac
fix(vrt): test image width
emmenko May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/hot-glasses-beam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@commercetools-frontend/application-components': patch
'@commercetools-frontend/application-shell': patch
'@commercetools-frontend/assets': patch
---

Update illustrations leftovers and use correct illustrations for maintenance pages
4 changes: 2 additions & 2 deletions packages/application-components/src/components/page-not-found/page-not-found.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useIntl, FormattedMessage } from 'react-intl';
import PageNotFoundIllustration from '@commercetools-frontend/assets/images/page-application-disabled.svg';
import PageNotFoundSVG from '@commercetools-frontend/assets/images/page-not-found.svg';
import { SUPPORT_PORTAL_URL } from '@commercetools-frontend/constants';
import MaintenancePageLayout from '../maintenance-page-layout';
import messages from './messages';
Expand All @@ -15,7 +15,7 @@ const PageNotFound = () => {

return (
<MaintenancePageLayout
imageSrc={PageNotFoundIllustration}
imageSrc={PageNotFoundSVG}
title={<FormattedMessage {...messages.title} />}
label={intl.formatMessage(messages.title)}
paragraph1={
Expand Down
4 changes: 2 additions & 2 deletions packages/application-components/src/components/page-unauthorized/page-unauthorized.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useIntl, FormattedMessage } from 'react-intl';
import FailedAuthorizationIllustration from '@commercetools-frontend/assets/images/folder-full-locked.svg';
import FailedAuthorizationSVG from '@commercetools-frontend/assets/images/doors-closed.svg';
import { SUPPORT_PORTAL_URL } from '@commercetools-frontend/constants';
import MaintenancePageLayout from '../maintenance-page-layout';
import messages from './messages';
Expand All @@ -16,7 +16,7 @@ export const PageUnauthorized = () => {

return (
<MaintenancePageLayout
imageSrc={FailedAuthorizationIllustration}
imageSrc={FailedAuthorizationSVG}
title={<FormattedMessage {...messages.title} />}
label={intl.formatMessage(messages.title)}
paragraph1={<FormattedMessage {...messages.paragraph1} />}
Expand Down
2 changes: 1 addition & 1 deletion packages/application-shell/src/components/authenticated/oidc-callback-error-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
PublicPageLayout,
themesOverrides,
} from '@commercetools-frontend/application-components';
import FailedAuthenticationSVG from '@commercetools-frontend/assets/images/locked-diamond.svg';
import FailedAuthenticationSVG from '@commercetools-frontend/assets/images/doors-closed.svg';
import type { TAsyncLocaleDataProps } from '@commercetools-frontend/i18n';

import { AsyncLocaleData } from '@commercetools-frontend/i18n';
Expand Down
4 changes: 2 additions & 2 deletions packages/application-shell/src/components/error-apologizer/error-apologizer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { useIntl, FormattedMessage } from 'react-intl';
import { MaintenancePageLayout } from '@commercetools-frontend/application-components';
import UnexpectedErrorIllustration from '@commercetools-frontend/assets/images/unexpected-error.svg';
import UnexpectedErrorSVG from '@commercetools-frontend/assets/images/unexpected-error.svg';
import messages from './messages';

const ErrorApologizer = () => {
const intl = useIntl();

return (
<MaintenancePageLayout
imageSrc={UnexpectedErrorIllustration}
imageSrc={UnexpectedErrorSVG}
title={<FormattedMessage {...messages.title} />}
label={intl.formatMessage(messages.title)}
paragraph1={<FormattedMessage {...messages.notifiedTeam} />}
Expand Down
2 changes: 1 addition & 1 deletion packages/application-shell/src/components/failed-authentication/failed-authentication.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useIntl, FormattedMessage } from 'react-intl';
import { MaintenancePageLayout } from '@commercetools-frontend/application-components';
import FailedAuthenticationSVG from '@commercetools-frontend/assets/images/locked-diamond.svg';
import FailedAuthenticationSVG from '@commercetools-frontend/assets/images/doors-closed.svg';
import messages from './messages';

const FailedAuthentication = () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/application-shell/src/components/project-not-found/project-not-found.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useIntl, FormattedMessage } from 'react-intl';
import { MaintenancePageLayout } from '@commercetools-frontend/application-components';
import FailedAuthorizationIllustration from '@commercetools-frontend/assets/images/folder-full-locked.svg';
import ProjectNotFoundSVG from '@commercetools-frontend/assets/images/folder-full-locked.svg';
import ServicePageProjectSwitcher from '../service-page-project-switcher';
import messages from './messages';

Expand All @@ -9,7 +9,7 @@ const ProjectNotFound = () => {

return (
<MaintenancePageLayout
imageSrc={FailedAuthorizationIllustration}
imageSrc={ProjectNotFoundSVG}
title={<FormattedMessage {...messages.title} />}
label={intl.formatMessage(messages.title)}
paragraph1={<FormattedMessage {...messages.paragraph1} />}
Expand Down
4 changes: 2 additions & 2 deletions ...ages/application-shell/src/components/project-not-initialized/project-not-initialized.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useIntl, FormattedMessage } from 'react-intl';
import { MaintenancePageLayout } from '@commercetools-frontend/application-components';
import ProjectNotInitializedIllustration from '@commercetools-frontend/assets/images/hourglass.svg';
import ProjectNotInitializedSVG from '@commercetools-frontend/assets/images/hourglass.svg';
import ServicePageProjectSwitcher from '../service-page-project-switcher';
import messages from './messages';

Expand All @@ -20,7 +20,7 @@ const ProjectNotInitialized = () => {

return (
<MaintenancePageLayout
imageSrc={ProjectNotInitializedIllustration}
imageSrc={ProjectNotInitializedSVG}
title={<FormattedMessage {...messages.title} />}
label={intl.formatMessage(messages.title)}
paragraph1={
Expand Down
2 changes: 1 addition & 1 deletion packages/application-shell/src/components/project-suspended/project-suspended.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useIntl, FormattedMessage, MessageDescriptor } from 'react-intl';
import { MaintenancePageLayout } from '@commercetools-frontend/application-components';
import ProjectSuspendedSVG from '@commercetools-frontend/assets/images/doors-closed.svg';
import ProjectSuspendedSVG from '@commercetools-frontend/assets/images/locked-diamond.svg';
import ServicePageProjectSwitcher from '../service-page-project-switcher';
import messages from './messages';

Expand Down
66 changes: 26 additions & 40 deletions packages/assets/images/doors-closed.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading