Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vite config for playground app #3152

Merged
merged 4 commits into from
Aug 4, 2023
Merged

fix: vite config for playground app #3152

merged 4 commits into from
Aug 4, 2023

Conversation

kark
Copy link
Contributor

@kark kark commented Aug 2, 2023

Summary

The issue:
Screenshot 2023-08-02 at 13 43 29

This worked for me.
As an alternative we could downgrade vite in the monorepo to 4.1.4.

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: aa1bd8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@commercetools-website/components-playground Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-local/visual-testing-app Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-local/playground Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/custom-applications Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-f93ku2zuo-commercetools.vercel.app
https://appkit-sha-04da0040ce608985ad13bbdb1ad8a9ff7a3b3504.commercetools.vercel.app
https://appkit-pr-3152.commercetools.vercel.app

Built with commit aa1bd8f.
This pull request is being automatically deployed with vercel-action

@kark kark requested a review from a team August 2, 2023 11:09
Copy link
Contributor

@chloe0592 chloe0592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix! 🙇‍♀️

Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@CarlosCortizasCT
Copy link
Contributor

When installing the dependencies, I see this warning in the terminal:
image

The playground seems to work anyway, but maybe we would need to consider downgrading that package as well.

@kark
Copy link
Contributor Author

kark commented Aug 3, 2023

When installing the dependencies, I see this warning in the terminal: image

The playground seems to work anyway, but maybe we would need to consider downgrading that package as well.

Thanks, that's a good catch.
We need to go down one major version.
I think we weren't using any new features of the plugin though:
https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md#400-2023-04-20

Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@kark kark merged commit 064bb2f into main Aug 4, 2023
10 checks passed
@kark kark deleted the kk-playground-fix branch August 4, 2023 07:20
@kark kark restored the kk-playground-fix branch September 27, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants