-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include CustomViewSelector
component in page components VRTs
#3246
Conversation
🦋 Changeset detectedLatest commit: e226a61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit e226a61. |
631dcd3
to
538c51b
Compare
58002fc
to
f01fdc7
Compare
f01fdc7
to
cddb6d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the enhancements in the VRT app, and great idea with using the Apollo cache! 🙌
Summary
Include
CustomViewSelector
component in page components VRTsDescription
The new component needs to fetch data from a GraphQL endpoint and this is a new requirement for the Visual Testing application.
In this PR I'm proposing to include the
@apollo/client
dependency and pre-populate its cache with some mocked data so we don't need to hit any external service nor mock the request.