Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CustomViewSelector component in page components VRTs #3246

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

CarlosCortizasCT
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT commented Oct 3, 2023

Summary

Include CustomViewSelector component in page components VRTs

Description

The new component needs to fetch data from a GraphQL endpoint and this is a new requirement for the Visual Testing application.

In this PR I'm proposing to include the @apollo/client dependency and pre-populate its cache with some mocked data so we don't need to hit any external service nor mock the request.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

🦋 Changeset detected

Latest commit: e226a61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/application-components Patch
@commercetools-local/visual-testing-app Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-local/playground Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/custom-applications Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-fmr9cj6yp-commercetools.vercel.app
https://appkit-sha-0555292805fc24291405f0a7a17b1331a8543efa.commercetools.vercel.app
https://appkit-pr-3246.commercetools.vercel.app

Built with commit e226a61.
This pull request is being automatically deployed with vercel-action

@CarlosCortizasCT CarlosCortizasCT marked this pull request as ready for review October 4, 2023 06:43
@emmenko emmenko force-pushed the SHIELD-840-custom-views-selector branch from 631dcd3 to 538c51b Compare October 9, 2023 13:51
Base automatically changed from SHIELD-840-custom-views-selector to main October 10, 2023 13:20
@emmenko emmenko force-pushed the SHIELD-840-custom-views-selector_vrts branch from 58002fc to f01fdc7 Compare October 10, 2023 14:29
@emmenko emmenko force-pushed the SHIELD-840-custom-views-selector_vrts branch from f01fdc7 to cddb6d6 Compare October 10, 2023 14:31
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancements in the VRT app, and great idea with using the Apollo cache! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants