chore: update react-select to version 3 #819
Conversation
| option => has(option, 'value') && option.value === props.value | ||
| ) || null, | ||
| selectedOptions: | ||
| props.isMulti && props.value |
There was a problem hiding this comment.
needed to add && props.value because when you clear multi select now, it sends null
There was a problem hiding this comment.
going to remove this since we will wrap the breaking change
| "treeshaked": { | ||
| "rollup": { | ||
| "code": 354503, | ||
| "import_statements": 910 | ||
| "code": 429358, |
There was a problem hiding this comment.
this goes up, but hopefully it's a win due to not shipping two versions of emotion 🤷♂ 🤔
There was a problem hiding this comment.
Hmmm, but shouldn't that make the bundle size go down?
There was a problem hiding this comment.
I don't think size snapshot includes dependencies.
There was a problem hiding this comment.
Ah, alright, then it makes sense.
There was a problem hiding this comment.
I'm not 100% sure how size snapshot works to be honest. But I wouldn't hold back a dependency update just to save a few kb 🤷♂
|
I'll do the react-testing-library update in another pr |
| AsyncCreatable as AsyncCreatableSelect, | ||
| } from 'react-select'; | ||
| import { components as defaultComponents } from 'react-select'; | ||
| import AsyncCreatableSelect from 'react-select/async-creatable'; |
There was a problem hiding this comment.
Are they doing this on purpose to have better treeshaking?
There was a problem hiding this comment.
Yeah
this is what they said
"This should have no bundle-size impact on react-select consumers currently leveraging tree-shaking. However for consumers who aren’t leveraging tree-shaking, this should help alleviate some of the bundle-weight."
montezume
force-pushed
the
ml-use-react-select-3
branch
from
6fb573f
to
2270721
Compare
Summary
Updates dependency
react-selectto version 3.See this issue for more details on the changes
The main advantage for us is that with version 3, react-select now relies on @emotion 10. This means we won't be shipping two versions of emotion.
I'll update some other deps here too