Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run benchmarks specified as build targets #1412

Closed
mgsloan opened this issue Nov 24, 2015 · 2 comments
Closed

Only run benchmarks specified as build targets #1412

mgsloan opened this issue Nov 24, 2015 · 2 comments
Labels
awaiting pull request newcomer friendly type: enhancement
Milestone
P2: Should

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Nov 24, 2015

Currently which benchmark targets are selected is ignored when actually running them - see this FIXME. Should be as simple as providing the benchmarks as component parameters here, and testing that it works properly.
@mgsloan mgsloan added this to the P2: Should milestone Nov 24, 2015
@rvion
Copy link
Contributor

rvion commented Nov 24, 2015

link above in description is broken, correct url is : https://github.com/commercialhaskell/stack/blob/master/src/Stack/Build/Execute.hs#L1281

@mgsloan
Copy link
Contributor Author

mgsloan commented Nov 25, 2015

Ah, yes, fixed. That's what I get for using unpushed SHAs! (I've got an emacs keybinding that creates a github url based on the current SHA + line)

mgsloan added a commit that referenced this issue Nov 25, 2015
@mgsloan
Merge pull request #1424 from luigy/master
1482c5c 
Only run benchmarks specified as build targets (closes #1412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting pull request newcomer friendly type: enhancement
Projects
None yet
Milestone
P2: Should
Development

No branches or pull requests
2 participants
@mgsloan @rvion