Nix: select the right GHC version in more cases. #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack now selects the correct GHC version in the following cases: * an abstract resolver was given, * a concrete resolver was given, * a compiler version was given. Previously, we could only deal with concrete resolvers correctly. Fixes #1641.
| @@ -0,0 +1,5 @@ | |||
| module Stack.Types.Config where | |||
There was a problem hiding this comment.
Note: An alternative to using an .hs-boot file is to parameter NixOpts over the resolver type. I found the .hs-boot file to be less verbose in the end.
|
cc @YPares |
borsboom
added a commit
that referenced
this pull request
Jan 12, 2016
Nix: select the right GHC version in more cases.
|
LGTM, and I'll try to apply this approach to Docker as well. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack now selects the correct GHC version in the following cases:
Previously, we could only deal with concrete resolvers correctly. So
e.g.
should now use GHC-7.8.4 from the nixpkgs repo. I think exactly the same
approach should be workable for Docker too, but how exactly the use case
should work there is less clear to me.
Fixes #1641.