-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install GHC from file #2232
Install GHC from file #2232
Conversation
Thanks for working on this! |
Why not allow setting Also, other places that use I guess the resolution of this would be to have I realize that's a fair bit of refactoring atop this. I can go ahead and merge if you don't want to do that (and probably get around to it myself at some point) |
OK, I'm removing warnings about them. |
I didn't change chattyDownload, because downloading to specified path is strange — it is actually copying and it's always better to use file from original location on disk than copying it to another directory. Or not always? |
Right, we'd want to call it something different. I understand why you didn't make the change that way, it would be larger. I don't think that this verification stuff should be coupled with downloading and should be split up. I can worry about that decoupling, though. |
Merged! Sorry for letting this languish. |
Thanks! |
Implements #2224.
Should I write tests?