Fix issue #2289, apply ghc-options to snapshot pkg #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit c891a24 created a regression, ghc-options were no longer applied to packages in the snapshot. The "mini build plan" for missing snapshot packages did not check the configuration's "ghc-options" settings at all, so even configurations with "apply-ghc-options: everything" would not apply those options. This commit, combined with a change to config.yaml, fixes these issues: DanielG/ghc-mod#762 IHaskell/IHaskell#636 To fix those issues, (usually located in ) should contain: And for snapshots already installed, the following command will force stack to rebuild them with those options: *Not tested:* Alternatively, add the line to . This may cause undesirable behavior in forcing all ghc-options changes to rebuild the snapshot.
|
Pinging @mgsloan |
|
Thanks a bunch for figuring this out and opening a PR!! |
|
Is there any information on when this fix might land in release? |
I agree that this an important bugfix that should be released as soon as possible. There's another open bug that will have to be fixed before a release is possible though: #2296 |
|
New release soon, now that the other issue has been closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c891a24 created a regression, ghc-options were no longer applied to
packages in the snapshot. The "mini build plan" for missing snapshot packages
did not check the configuration's "ghc-options" settings at all, so even
configurations with "apply-ghc-options: everything" would not apply those
options.
This commit, combined with a change to config.yaml, fixes these issues:
DanielG/ghc-mod#762
IHaskell/IHaskell#636
To fix those issues,
config.yaml(usually located in~/.stack) shouldcontain:
And for snapshots already installed, the following command will force stack
to rebuild them with those options:
Not tested: Alternatively, add the line
rebuild-ghc-options: truetoconfig.yaml. This may cause undesirable behavior in forcing all ghc-optionschanges to rebuild the snapshot.