-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cabal custom setup #2866
Cabal custom setup #2866
Conversation
2c33b6d
to
c42b7b3
Compare
c42b7b3
to
9192667
Compare
@@ -25,6 +25,10 @@ Other enhancements: | |||
closing [#877](https://github.com/commercialhaskell/stack/issues/877). | |||
* `stack haddock` now shows index.html paths when documentation is alread up to | |||
date. Resolved [#781](https://github.com/commercialhaskell/stack/issues/781) | |||
* Respects the `custom-setup` field introduced in Cabal 1.24. This | |||
supercedes any `explicit-setup-deps` setings in your `stack.yaml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/setings/settings/g
getPackageArgs = | ||
case (packageSetupDeps package, mdeps) of | ||
-- The package is using the Cabal custom-setup | ||
-- configuraiton introduced in Cabal 1.24. In |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/configuraiton/configuration/g
Just what I need! This isn't out yet right? I have stack v1.3.2 and get:
Curious, will this be in 1.3.3? Edit: I see from the commit it's for 1.4, cool |
@metaleap, try The functionality is in HEAD. |
I would, had I not just found out about stack's |
Ah! It would be cool but I already moved city. But send my regards! Good people. 👍 |
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
I'm still testing this in a more complex use case. However, the simple test case I devised was:
stack new foo
Modify the
Setup.hs
file to addimport Acme.Missiles
Add
acme-missiles-0.3
as an extra-depAdd the following
custom-setup
block tofoo.cabal
:Set
build-type
toCustom
Confirm that without the patch, the package refuses to compile. With the patch, it compiles just fine.
@borsboom Maybe we can sync up later on adding this as an integration test case?