Aggressive unregister for #2904 #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit (fixing #2904) made the Maybe layer confusing and error-prone. It was too easy to end up accidentally skipping an unregister based on the two levels of Maybe wrapping. This simplifies the codebase, without any change in behavior. It would be even nicer to be able to prove statically that we always generate a dirty reason.
|
LGTM! Nice solution. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!
Tested by following the repro steps in #2904.
I've made this PR against the release candidate branch since #2904 is marked as P1. @borsboom I leave it to your judgement whether this should be instead merged to master, and can update the PR accordingly.
CC @mgsloan @spikefoo