Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save Hackage credentials without asking first #3436

Merged
merged 2 commits into from
Sep 17, 2017
Merged

Don't save Hackage credentials without asking first #3436

merged 2 commits into from
Sep 17, 2017

Conversation

decentral1se
Copy link
Member

Something for #2159.

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Here's my manual test logs:

>> :main ["upload", "."]
Getting file list for /home/lwm/hacking/hobby/stack/

Warning: In getPackageArgs: custom-setup in use, but no dependency map present
Could not find custom-setup dep: Cabal
Could not find custom-setup dep: base
Could not find custom-setup dep: filepath
Building sdist tarball for /home/lwm/hacking/hobby/stack/
Checking package 'stack' for common mistakes
Hackage username: foobar
Hackage password: 
Save hackage credentials to file at /home/lwm/.stack/upload/credentials.json [y/n]? bad input
Save hackage credentials to file at /home/lwm/.stack/upload/credentials.json [y/n]? n
NOTE: Avoid this prompt in the future by using: save-hackage-creds: false
Uploading stack-1.5.1.tar.gz... authentication failure
Control.Exception.Safe.throwString called with:

Authentication failure uploading to server
Called from:
  throwString (/home/lwm/hacking/hobby/stack/src/Stack/Upload.hs:181:17 in main:Stack.Upload)

*** Exception: ExitFailure 1

@decentral1se
Copy link
Member Author

decentral1se commented Sep 17, 2017

Weird CI error - https://travis-ci.org/commercialhaskell/stack/jobs/276544532#L455. Possibly related to #3421. Seems like more of an upstream Travis thing (see travis-ci/travis-ci#7752)? Pretty sure that is unrelated ... will investigate.Rebuilt it but the time out persists :| Fixed 👍

@mgsloan
Copy link
Contributor

mgsloan commented Sep 17, 2017

LGTM, good stuff!

@mgsloan mgsloan merged commit 96e83a0 into commercialhaskell:master Sep 17, 2017
@decentral1se decentral1se deleted the prompt-creds branch September 17, 2017 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants