Implement #3264 adding --cwd to exec #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome for any suggestions as to better methods to use/docs to update.
mgsloan
suggested changes
Oct 17, 2017
src/main/Main.hs
Outdated
| @@ -788,6 +789,20 @@ execCmd ExecOpts {..} go@GlobalOpts{..} = | |||
| pkgopts <- getPkgOpts menv wc pkgs | |||
| return (prefix ++ compilerExeName wc, pkgopts ++ args) | |||
|
|
|||
| runWithPath path callback = case path of | |||
| Nothing -> callback | |||
| Just p | not (isValid p) -> callback | |||
There was a problem hiding this comment.
Hmm, it seems like this would silently ignore --cwd for invalid paths. Is there a reason for this? Seems to me like it should throw an error.
src/main/Main.hs
Outdated
| Nothing -> callback | ||
| Just p | not (isValid p) -> callback | ||
| Just p -> | ||
| if isRelative p |
There was a problem hiding this comment.
I think it'd be cleaner to just use System.Directory.withCurrentDirectory. I wish path had RelOrAbs or something, but for now FilePath is the best way to represent having either.
|
|
||
| eoCwdParser :: Parser (Maybe FilePath) | ||
| eoCwdParser = optional | ||
| (strOption (long "cwd" |
There was a problem hiding this comment.
Please also add
metavar "DIR" <>
completer dirCompleter <>
For better help output and path completion for this option.
* Use System.Directory.withCurrentDirectory * Throw an exception for invalid paths * Add in better options
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature requested by #3264 - tested it locally with stack exec.
Welcome for any suggestions as to better methods to use/docs to update.