Mark ghcjs support as experimental #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2018 11:17
…ote on matchwood ghcjs versions for lts 8 and 9
matchwood
changed the title
dbaynard
approved these changes
Jul 17, 2018
| ### Recent versions of GHCJS, repacked for stack | ||
| ### GHCJS repacked for snapsnots lts-8 and lts-9 | ||
|
|
||
| Please see the [ghcjs-stack-dist repository](https://github.com/matchwood/ghcjs-stack-dist) for `lts-8` and `lts-9` configurations and refer to the [README](https://github.com/matchwood/ghcjs-stack-dist/blob/master/README.md) for common issues. |
There was a problem hiding this comment.
I take it we can't just have a table like for the earlier snapshots?
There was a problem hiding this comment.
We could but I'd prefer people engaged with the README on the ghcjs-stack-dist repo (as there are some important issues flagged up there) and I didn't want to just copy across all that info. If and when we get a better story for ghcjs support I will rewrite the docs and put everything in a table etc.
|
As @bitemyapp has just changed these files, I'm requesting a review from him — mainly to check there's nothing missing. |
bitemyapp
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes deprecation warning into experimental warning and makes relevant changes to documentation.
Fixes #4086 .