Remove suggestions for legacy packages syntax
#4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stack no longer parses this syntax. The suggestion has been moved to an improved comment section for `extra-deps`.
fosskers
commented
Oct 1, 2018
| @@ -274,15 +274,23 @@ renderStackYaml p ignoredPackages dupPackages = | |||
| , "packages:" | |||
| , "- some-directory" | |||
| , "- https://example.com/foo/bar/baz-0.0.2.tar.gz" | |||
There was a problem hiding this comment.
Is this still legal, or should this be in extra-deps too?
| , "- location:" | ||
| , " git: https://github.com/commercialhaskell/stack.git" | ||
| , " commit: e7b331f14bcffb8367cd58fbfc8b40ec7642100a" | ||
| , "- location: https://github.com/commercialhaskell/stack/commit/e7b331f14bcffb8367cd58fbfc8b40ec7642100a" | ||
| , " subdirs:" |
There was a problem hiding this comment.
Is the indentation here correct?
|
The CI failures seem to be a Travis timeout. |
mihaimaruseac
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stackversion:masteras ofa299ac652fde49d3b4b6a199c1a206220826da68Stack no longer parses the
locationsyntax, but still suggests it to users in examples in astack.yamlproduced bystack new.This PR moves the suggestions to an improved comment section for
extra-deps.