Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack clean does not need ghc-pkg (fixes #4480) #4607

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Mar 6, 2019

When running stack clean, the entire .stack-work/dist directory will
now be deleted, not just the subdirectory for the current GHC/Cabal
combination.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

When running `stack clean`, the entire .stack-work/dist directory will
now be deleted, not just the subdirectory for the current GHC/Cabal
combination.
Copy link
Contributor

@qrilka qrilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snoyberg snoyberg merged commit 33cf3fa into master Mar 7, 2019
@snoyberg snoyberg deleted the 4480-fix-stack-clean branch March 7, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants