Hackage creds are read-only (fixes #2159) #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
force-pushed
the
2159-creds-not-world-readable
branch
2 times, most recently
from
29d4801
to
fba88af
Compare
nh2
requested changes
Mar 29, 2019
nh2
approved these changes
Mar 30, 2019
There was a problem hiding this comment.
Looks good to me.
Only remaining thing I'd do is, in the comments in writeFilePrivate, link to the docs of openTempFile as reference that the permissions are set up for the user only (in case somebody changes that upstream in the future), and link to the discussion in #2159 (comment) as well.
|
Comments added, thanks for the review @nh2! |
snoyberg
force-pushed
the
2159-creds-not-world-readable
branch
from
70458b2
to
d0e99ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!