Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHC Hide Source Paths #4736

Merged
merged 5 commits into from
Apr 15, 2019
Merged

GHC Hide Source Paths #4736

merged 5 commits into from
Apr 15, 2019

Conversation

mauriciofierrom
Copy link
Contributor

@mauriciofierrom mauriciofierrom commented Apr 14, 2019 •
edited
Loading

Add ghc-option to hide source paths when using ghc >= 8.2 as detailed in #3784.

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

To test

  • The default output for compiling modules should hide the source paths
  • The entry hide-source-paths in stack.yaml set to false should restore including the source paths
  • The entry hide-source-paths in stack.yaml set to true should hide the source paths (as the default behavior)

E.g.:
When enabled:

...
[1 of 2] Compiling Lib
[2 of 2] Compiling Paths_test_pr
...

When disabled:

...
[1 of 2] Compiling Lib              ( src/Lib.hs, .stack-work/dist/x86_64-linux-tinfo6/Cabal-2.4.0.1/build/Lib.o )
...

@mauriciofierrom mauriciofierrom changed the title GHC Hide Source Paths [WIP] GHC Hide Source Paths Apr 14, 2019
@mauriciofierrom mauriciofierrom force-pushed the 3784-hide-source-paths branch 2 times, most recently from 5723b6c to 2c7a685 Compare April 14, 2019 22:32
@mauriciofierrom mauriciofierrom changed the title [WIP] GHC Hide Source Paths GHC Hide Source Paths Apr 15, 2019
@mauriciofierrom
Copy link
Contributor Author

mauriciofierrom commented Apr 15, 2019 •
edited
Loading

Hi @snoyberg. I think this is ready for a review please. Also, I have a couple of questions:

I'm getting this warning locally:

Warning: /home/mauricio/projects/haskell/test-pr/stack.yaml: Unrecognized field in ProjectAndConfigMonoid: hide-source-paths

Which seems related to pantry, but the stack executable works as expected. Am I missing something?

Also, should this change be included in the Changelog?

@snoyberg
Copy link
Contributor

I'm getting this warning locally:

Are you getting that when running with the old or new version of Stack? It's expected with the old version, since it's unaware of that setting. With the new version there's definitely something weird going on.

Also, should this change be included in the Changelog?

Totally forgot about that, yes please!

snoyberg
snoyberg requested changes Apr 15, 2019
View reviewed changes
doc/yaml_configuration.md Outdated
@@ -1045,3 +1045,25 @@ a yaml configuration file.

(The British English spelling (colour) is also accepted. In yaml configuration
files, the American spelling is the alternative that has priority.)

### hide-source-directories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say hide-source-paths instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry!

doc/yaml_configuration.md Show resolved Hide resolved
@snoyberg
Copy link
Contributor

LGTM, thanks!

@snoyberg snoyberg merged commit 3f97553 into commercialhaskell:master Apr 15, 2019
@snoyberg snoyberg mentioned this pull request Apr 15, 2019
Closed
@chshersh chshersh mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauriciofierrom @snoyberg