Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to upcoming Cabal installed package identifier format change #902

Merged
merged 2 commits into from
Sep 2, 2015
Merged

Adapt to upcoming Cabal installed package identifier format change #902

merged 2 commits into from
Sep 2, 2015

Conversation

snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Sep 2, 2015

Fixes #851

@snoyberg snoyberg added this to the 0.3.0.0 milestone Sep 2, 2015
@snoyberg snoyberg mentioned this pull request Sep 2, 2015
Closed
chrisdone
chrisdone reviewed Sep 2, 2015
View reviewed changes
src/Stack/Types/GhcPkgId.hs
putWord8 1
putWord8 3
putWord8 4
putWord8 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this shenanigans?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the binary format being read is the same one that was written. See: #889

@chrisdone
Copy link
Member

I'm happy with this patch. Seems pretty mechanical. Laborious to do, but straight-forward updates.

@snoyberg
Copy link
Contributor Author

snoyberg commented Sep 2, 2015

I'd say: let's merge this in immediately after the next release is cut. I don't want to rock the boat on this release for such a non-urgent change, but would like to maximize testing during the next release cycle. Similar thoughts apply to #887. @borsboom sound good?

@chrisdone
Copy link
Member

👍

@borsboom borsboom merged commit fa389a5 into master Sep 2, 2015
@borsboom borsboom deleted the 851-arbitrary-ipids branch September 2, 2015 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@borsboom borsboom

Labels
None yet
Projects
None yet
Milestone
P2: Should
Development

Successfully merging this pull request may close these issues.
3 participants
@snoyberg @chrisdone @borsboom