refactor(Commit): Added deprecation on git signoff mechanic

Signoff dedicated code is no longer necessary & removed #TODO as tests show identical args and extra-args are not an issue.
commitizen-tools · Oct 17, 2023 · 069fbb7 · 069fbb7
1 parent e91ea40
commit 069fbb7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/commitizen/cli.py b/commitizen/cli.py
@@ -465,7 +465,6 @@ def main():
             raise InvalidCommandArgumentError(
                 f"Invalid commitizen arguments were found before -- separator: `{' '.join(unknown_args[:pos])}`. "
             )
-        # TODO: treat case when extra-args and commitizen args are identical
         extra_args = " ".join(unknown_args[1:])
         arguments["extra_cli_args"] = extra_args
 

diff --git a/commitizen/commands/commit.py b/commitizen/commands/commit.py
@@ -98,6 +98,7 @@ def __call__(self):
         )
 
         if signoff:
+            out.warn("signoff mechanic is deprecated, please use `cz commit -- -s` instead.")
             c = git.commit(m, "-s")
 
         if self.arguments.get("extra_cli_args"):