-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for scoped adapters? #403
Labels
Comments
It hasn't be brought up yet but yes we will need a fix for this. |
Patch for this is coming. |
jimthedev
added a commit
that referenced
this issue
Dec 18, 2016
Add a test for scoped npm modules to confirm that they are not treated incorrectly as paths. Closes #403
Release will happen as soon as I can get CI to work. |
Good stuff, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
resolveAdapterPath
uses Node'spath.parse
method, and examines thedir
property to determine if the adapter path is an npm module name, or a path.adapter.js:129-131
However, this will incorrectly assign scoped packages as paths (e.g.
inboundAdapterPath === '@foo/bar'
).Is there a plan to support scoped packages?
The text was updated successfully, but these errors were encountered: