precommit runs twice when using husky

[faceyspacey]

Here's my relevant package.json:

"devDependencies": {
    "commitizen": "^2.9.6",
    "cz-conventional-changelog": "^2.0.0",
    "husky": "^0.13.2",
    "lint-staged": "^3.4.0",
    "prettier": "^1.2.2"
},
"scripts": {
   "precommit": "lint-staged --verbose",
   "commit": "git-cz",
},
"lint-staged": {
    "*.js": [
      "prettier --single-quote --semi=false --write",
      "git add"
    ]
},
"config": {
    "commitizen": {
      "path": "./node_modules/cz-conventional-changelog"
    }
},

lint-staged is correctly called once before the commitizen command line form appears, and then incorrectly husky - npm run -s precommit is run after. Typically without commitizen only lint-staged is called. Somehow commitizen is triggering husky to be called. No where do I have this script: npm run -s precommit. It seems commitizen somehow triggers it after you complete the form.

[jimthedev]

Can you post what your workflow looks like without commitizen in the mix including when and how you run git add and git commit in this configuration?

…

-- Jim ForCy

On May 2, 2017 at 3:42:08 AM, James Gillmore ***@***.***) wrote: Here's my relevant package.json: "devDependencies": { "commitizen": "^2.9.6", "cz-conventional-changelog": "^2.0.0", "husky": "^0.13.2", "lint-staged": "^3.4.0", "prettier": "^1.2.2" },"scripts": { "precommit": "lint-staged --verbose", "commit": "git-cz", },"lint-staged": { "*.js": [ "prettier --single-quote --semi=false --write", "git add" ] },"config": { "commitizen": { "path": "./node_modules/cz-conventional-changelog" } }, lint-staged is called once before the commitizen command line form appears, and husky - npm run -s precommit is run after. Typically without commitizen only lint-staged is called. Somehow commitizen is triggering husky to be called. No where do I have this script: npm run -s precommit. It seems commitizen somehow triggers it after you complete the form. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#432>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGpinNk5OrShdPajuyOF6g25wGcD21Mks5r1uxggaJpZM4NN3Qk> .

[faceyspacey]

I simply call git add, and git commit. The precommit script thanks to husky will run lint-staged. So you will see husky - npm run -s precommit as the log in the terminal (this is the same as the second log after the commitizen form).

Whereas if you run npm run commit for the first commit log you see:

> redux-first-router@0.0.0-development precommit /Users/jamesgillmore/React/redux-first-router
> lint-staged --verbose && npm test

Basically it seems 2 different versions of precommit are being run when commitizen is used, as they are logged with different messages.

ps. when is the precommit hook supposed to run relative to Commitizen? Before or after? Because it seems perhaps the correct hook is running after the form, as it has the same log as without commitizen. So perhaps what we want is the 2nd hook, but only to run before the commitizen form.

[faceyspacey]

Here's a package you can clone and immediately see it in action:

https://github.com/faceyspacey/redux-first-router

[jimthedev]

That is a bug in husky that happens due to a "feature" of npm-scripts that auto run scripts with the name prexxx where xxx is the name of another script. So, because you're using commit and precommit it is running them twice.

Until husky fixes this you can simply change your commitizen task to cmt or something else (cz, co, etc).

We could probably update our docs to reflect that when using commitizen and husky you should pick another name than npm run commit. Want to put in a PR?

[faceyspacey]

nice find!

Here's the PR as requested: #433