Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adapter): Don't print git root to stdout #428

Merged
merged 1 commit into from
May 9, 2017
Merged

fix(adapter): Don't print git root to stdout #428

merged 1 commit into from
May 9, 2017

Conversation

markhalliwell
Copy link
Contributor

Whenever this is ran, it also prints out to the console. This should just be silenced since it's just being used internally.

LinusU
LinusU approved these changes Apr 3, 2017
View reviewed changes
Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jimthedev
Copy link
Member

LGTM can you ament your commit to use our the convention? I am assuming this could just be a bugfix release.

@markhalliwell
Copy link
Contributor Author

Just did a force push with the correct commit message since there was nothing to amend.

@markhalliwell markhalliwell changed the title Don't print git root to stdout fix(adapter): Don't print git root to stdout May 9, 2017
@jimthedev jimthedev merged commit d5e2424 into commitizen:master May 9, 2017
@jimthedev
Copy link
Member

Cheers!

@markhalliwell markhalliwell deleted the patch-1 branch May 9, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markhalliwell @jimthedev @LinusU