Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow minor and patch updates to dependencies #965

Closed
wants to merge 1 commit into from
Closed

Allow minor and patch updates to dependencies #965

wants to merge 1 commit into from

Conversation

keeganstreet
Copy link

Currently most of the dependencies in this package are pinned to specific versions. This prevents consuming applications from being able to update these dependencies. This is particularly a problem when security vulnerabilities are found in dependencies, resulting in new versions of commitizen needing to be released i.e:

#963
#945
#931
#883

By using a ^ before the version number, consuming applications will be able to install minor and patch updates of commitizen's dependencies, which should still be compatible with commitizen according to semver principles.

Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is the way to go 👍

@keeganstreet
Copy link
Author

OK great! I better just fix up the commit message because I didn't actually use conventional commits 😅

Currently most of the dependencies in this package are pinned to specific versions. This prevents consuming applications from being able to update these dependencies. This is particularly a problem when security vulnerabilities are found in dependencies, resulting in new versions of commitizen needing to be released i.e:

#963
#945
#931
#883

By using a `^` before the version number, consuming applications will be able to install minor and patch updates of `commitizen`'s dependencies, which should still be compatible with `commitizen` according to semver principles.
@keeganstreet keeganstreet closed this by deleting the head repository Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants