-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed type_for_source logic #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 23.58% 29.49% +5.90%
==========================================
Files 27 27
Lines 20719 20738 +19
Branches 5777 5777
==========================================
+ Hits 4886 6116 +1230
+ Misses 14794 13292 -1502
- Partials 1039 1330 +291
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mr-c
requested changes
Aug 29, 2022
mr-c
approved these changes
Aug 29, 2022
also log error and keep going and add another test
mr-c
force-pushed
the
type-for-source-fix
branch
from
August 29, 2022 16:47
0e4eb49
to
1833fce
Compare
mr-c
force-pushed
the
type-for-source-fix
branch
from
August 29, 2022 17:00
1833fce
to
2c38c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
type_for_source
method from thecwl_*_expression_refactor.py
file to thecwl_*_utils.py
file and adjusts its logic to make it more general-purpose.This method can be used to infer the type of a
WorkflowStep
source
element at build time.