Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type_for_source logic #152

Merged
merged 7 commits into from
Aug 29, 2022
Merged

Fixed type_for_source logic #152

merged 7 commits into from
Aug 29, 2022

Conversation

GlassOfWhiskey
Copy link
Collaborator

This PR moves the type_for_source method from the cwl_*_expression_refactor.py file to the cwl_*_utils.py file and adjusts its logic to make it more general-purpose.

This method can be used to infer the type of a WorkflowStep source element at build time.

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #152 (2c38c41) into main (52d9669) will increase coverage by 5.90%.
The diff coverage is 82.81%.

❗ Current head 2c38c41 differs from pull request most recent head d7afb9d. Consider uploading reports for the commit d7afb9d to get more accurate results

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   23.58%   29.49%   +5.90%     
==========================================
  Files          27       27              
  Lines       20719    20738      +19     
  Branches     5777     5777              
==========================================
+ Hits         4886     6116    +1230     
+ Misses      14794    13292    -1502     
- Partials     1039     1330     +291     
Impacted Files Coverage Δ
cwl_utils/cwl_v1_0_expression_refactor.py 28.28% <50.00%> (+17.33%) ⬆️
cwl_utils/cwl_v1_1_expression_refactor.py 23.90% <50.00%> (+13.34%) ⬆️
cwl_utils/cwl_v1_2_expression_refactor.py 33.19% <57.14%> (+22.88%) ⬆️
cwl_utils/cwl_expression_refactor.py 79.26% <80.76%> (+79.26%) ⬆️
cwl_utils/parser/cwl_v1_1_utils.py 87.67% <85.71%> (-5.44%) ⬇️
cwl_utils/parser/cwl_v1_2_utils.py 87.67% <85.71%> (-5.44%) ⬇️
cwl_utils/parser/cwl_v1_0_utils.py 90.76% <89.79%> (-4.24%) ⬇️
cwl_utils/file_formats.py 88.23% <0.00%> (-5.89%) ⬇️
cwl_utils/parser/cwl_v1_0.py 29.37% <0.00%> (+2.29%) ⬆️
cwl_utils/parser/cwl_v1_1.py 26.33% <0.00%> (+2.63%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tests/test_parser_utils.py Outdated Show resolved Hide resolved
tests/test_parser_utils.py Outdated Show resolved Hide resolved
tests/test_parser_utils.py Outdated Show resolved Hide resolved
tests/test_parser_utils.py Outdated Show resolved Hide resolved
@mr-c mr-c enabled auto-merge (rebase) August 29, 2022 17:04
@mr-c mr-c merged commit 8ad7b09 into main Aug 29, 2022
@mr-c mr-c deleted the type-for-source-fix branch August 29, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants