Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packing: Allow $imports in type fields #222

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented May 16, 2023

Brings in rabix/sbpack#67

  • the packing tests that we didn't originally include when we brought in sbpack to cwl-utils

Brings in rabix/sbpack#67
+ the packing tests that we didn't originally include when we brought
in sbpack to cwl-utils

Co-authored-by: Thomas Hickman <thomas.hickman@genomicsplc.com>
@mr-c mr-c force-pushed the pack_allow-imports-in-type branch from 7e021b9 to eb82c1d Compare May 16, 2023 14:14
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #222 (eb82c1d) into main (4e8edbf) will increase coverage by 0.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   39.35%   40.26%   +0.90%     
==========================================
  Files          30       30              
  Lines       23449    23452       +3     
  Branches     6649     6650       +1     
==========================================
+ Hits         9229     9442     +213     
+ Misses      12191    11951     -240     
- Partials     2029     2059      +30     
Impacted Files Coverage Δ
cwl_utils/schemadef.py 67.61% <100.00%> (+67.61%) ⬆️

... and 2 files with indirect coverage changes

@mr-c mr-c merged commit 064be75 into main May 16, 2023
@mr-c mr-c deleted the pack_allow-imports-in-type branch May 16, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant