Sink type refactoring #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
sink-type-refactoring
branch
from
73f67a0
to
763eae2
Compare
Merged
This commit is motivated by the fact that the `linkMerge` and `pickValue` fields were repeated in the `Sink` and `WorkflowOutputParameter` types. To remove this repetition, these two fields have been isolated in a new type called `Sink`. The previous `Sink` type, which is now named `InputSink` extends `Sink` with the `source` field, while a new `OutputSink` type extends `Sink` with the `outputSource` field. The `WorkflowInputParameter` type extends the `InputSink`, while the `WorkflowOutputParameter` type inherits from `OutputSink`. Note that this separation will be useful also for future extensions. For example, the proposed `loop` feature will build upon the `OutputSink` type to map the step outputs into the inputs of the next iteration.
mr-c
force-pushed
the
sink-type-refactoring
branch
from
763eae2
to
64ca809
Compare
|
Object model before: Object model after: zoomed in: |
tetron
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is motivated by the fact that the
linkMergeandpickValuefields were repeated in theSinkandWorkflowOutputParametertypes.To remove this repetition, these two fields have been isolated in a new type called
Sink. The previousSinktype, which is now namedInputSinkextendsSinkwith thesourcefield, while a newOutputSinktype extendsSinkwith theoutputSourcefield.The
WorkflowInputParametertype extends theInputSink, while theWorkflowOutputParametertype inherits fromOutputSink. Note that this separation will be useful also for future extensions. For example, the proposedloopfeature will build upon theOutputSinktype to map the step outputs into the inputs of the next iteration.