Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace {distdir} with dist #212

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Replace {distdir} with dist #212

merged 1 commit into from
Jun 27, 2024

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Jun 26, 2024

This request is to fix #210.

As I mentioned in #210, the source of problem is that tox removed the distdir variable in 4.0.

An official document suggests to use $TOX_PACKAGE instead of {distdir}.
On the other hand, as reported in tox-dev/tox#2706, just replacing {distdir} with $TOX_PACKAGE does not work as we expected.

This request just replaces {distdir} with dist.
It is simple enough and I hope it works as we expected.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (dd269f3) to head (e00edc1).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   80.50%   80.50%           
=======================================
  Files           8        8           
  Lines         790      790           
  Branches      201      201           
=======================================
  Hits          636      636           
- Misses        115      117    +2     
+ Partials       39       37    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c merged commit c3a268f into main Jun 27, 2024
29 checks passed
@mr-c mr-c deleted the fix-distdir branch June 27, 2024 07:39
@tom-tan
Copy link
Member Author

tom-tan commented Jun 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox generates {distdir} directory
2 participants