Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty scatter bug #1669

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix empty scatter bug #1669

wants to merge 1 commit into from

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented May 20, 2022

fixes #1668

  • tests
    why did no conformance test trigger this? Scatter inputs in CWL v1.[012] must be arrays, not empty; so allowing this requires a change to the CWL standards

See #1668 (comment)

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1669 (86c6f8e) into main (8763bed) will increase coverage by 0.59%.
The diff coverage is 85.71%.

❗ Current head 86c6f8e differs from pull request most recent head db82bbb. Consider uploading reports for the commit db82bbb to get more accurate results

@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
+ Coverage   66.43%   67.02%   +0.59%     
==========================================
  Files          89       89              
  Lines       15908    15908              
  Branches     4216     4216              
==========================================
+ Hits        10569    10663      +94     
+ Misses       4240     4154      -86     
+ Partials     1099     1091       -8     
Impacted Files Coverage Δ
cwltool/workflow_job.py 76.88% <80.00%> (+17.11%) ⬆️
cwltool/executors.py 82.58% <100.00%> (ø)
cwltool/job.py 79.88% <100.00%> (ø)
cwltool/cwltool/workflow_job.py 81.11% <0.00%> (ø)
cwltool/cwltool/job.py 62.25% <0.00%> (+0.79%) ⬆️
cwltool/workflow.py 87.64% <0.00%> (+1.99%) ⬆️
cwltool/checker.py 89.78% <0.00%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mr-c mr-c marked this pull request as draft August 15, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter before a when occurs
1 participant