Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prov data input output #1989

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft

Prov data input output #1989

wants to merge 41 commits into from

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Apr 3, 2024

No description provided.

jjkoehorst and others added 19 commits June 5, 2023 11:34
@jjkoehorst
Init for the no listing workflow
e3eabfe
@jjkoehorst
improved test case with checking if the files are there and if they a…
ab0738f 
…re not there
@jjkoehorst
make clean formatting
c559952
@jjkoehorst
Improved naming for the no_listing test and a creation step of 10.000…
c62979a 
… files for performance testing
@jjkoehorst
Identifying what it is processing for provenance
bc85a1f
@jjkoehorst
For the provenance a --no-input option to not copy input files into t…
9a6f4ce 
…he provenance directory
@jjkoehorst
A work in progress to ensure the test works for no-listing and no-input
456b26c
@jjkoehorst
Wokring on specifying input/output for provenance
b278f58
@jjkoehorst
working on no-input
fd14f0d
@jjkoehorst
move back from data/input data/output to a data folder to see if RO-C…
95cff2b 
…rate can cover that part but still keep the no-input option
@jjkoehorst
Likely missed one
cdbf106
@jjkoehorst
Moved back to provenance_constants.DATA with comments for DATAX to kn…
4d8ae62 
…ow where the change for switchback could be needed
Merge branch 'main' into prov_data_input_output for updates
29eee5f
fix merge err
5fc090b
fix loadListing of dir for prov
18a9bd6
misc change of comments
fc0e331
fix text, remove vscode space files
627026c
remove redundant texts
96d1e20
@ElderMedic
Merge pull request #1986 from ElderMedic/prov_data_input_output
c7963b3 
Update and Check loadListing for input dir provenance
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.37624% with 38 lines in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (c3bd4ca) to head (52b256b).

Files Patch % Lines
cwltool/cwlprov/ro.py 43.18% 20 Missing and 5 partials ⚠️
cwltool/cwlprov/__init__.py 53.84% 6 Missing ⚠️
cwltool/cwlprov/provenance_profile.py 40.00% 6 Missing ⚠️
cwltool/cwlprov/writablebagfile.py 75.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (c3bd4ca) and HEAD (52b256b). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (c3bd4ca) HEAD (52b256b)
17 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1989       +/-   ##
===========================================
- Coverage   83.76%   70.08%   -13.69%     
===========================================
  Files          46       46               
  Lines        8262     8320       +58     
  Branches     2199     2114       -85     
===========================================
- Hits         6921     5831     -1090     
- Misses        861     1868     +1007     
- Partials      480      621      +141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjkoehorst
Copy link
Contributor

@mr-c I think I fixed the code make cleanup could you have a look at the other tests? Not sure if they fail due to this implementation.

mr-c
mr-c commented Jul 3, 2024
View reviewed changes
tests/test_provenance.py Outdated Show resolved Hide resolved
Changlin and others added 3 commits July 9, 2024 14:14
@ElderMedic
Copy link
Collaborator

@mr-c Hey! Would you review the --no-data --no-input implementation and give us some feedback if possible? Thanks! @

@mr-c
Copy link
Member Author

mr-c commented Jul 24, 2024

Hey @ElderMedic ! I just started a vacation. I'll be back next week. Feel free to ping me again if you don't hear from me in 2 weeks.

@fmigneault fmigneault mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-c @jjkoehorst @ElderMedic