-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix loadContents
for File[]
#2036
fix loadContents
for File[]
#2036
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2036 +/- ##
==========================================
- Coverage 83.80% 83.77% -0.03%
==========================================
Files 46 46
Lines 8267 8267
Branches 2201 2201
==========================================
- Hits 6928 6926 -2
- Misses 859 861 +2
Partials 480 480 ☔ View full report in Codecov by Sentry. |
Thank you @fmigneault ! Did you mean to add test code that uses the new test data in this PR? |
Yes. The test data submitted is used by the test CWL. |
@mr-c |
b740283
to
9c05bb7
Compare
@mr-c All tests resolved and working. |
@mr-c |
We don't have scheduled releases. Can you install from your fork? |
Yes, I can work with the fork in the meantime. |
77254ef
to
3936cb1
Compare
3936cb1
to
a492285
Compare
@mr-c Thanks! |
When a
type: File[]
is provided withloadContents: true
, thecontents
property of the respective files are NOT loaded. This does not respect the specification https://www.commonwl.org/v1.2/CommandLineTool.html#CommandInputParameter that indicates they should be loaded.@mr-c
I would really like to have this integrated as soon as possible, since this is blocking me for many integrations with geospatial community tools. Feel free to adjust, or let me know what I just adjust, to make this integrated quickly (I do not remember the procedure to integrate the test to the test pipeline).
The expected output of the provided test is
{"data": [1,2]}
.Without the changes, it results in
{"data":[null,null]}
(sincecontents
is missing).