Upgrading to Spring Boot 3 #568

kinow · 2023-09-26T17:24:54Z

Description

Upgrading to Spring Boot 3

Motivation and Context

#566 (comment)

Closes #576

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

docker-compose.yml

src/main/java/org/commonwl/view/cwl/CWLValidationException.java

src/main/java/org/commonwl/view/util/BaseEntity.java

src/main/java/org/commonwl/view/workflow/QueuedWorkflow.java

src/main/java/org/commonwl/view/workflow/QueuedWorkflowRepository.java

kinow · 2023-09-26T17:28:45Z

src/main/java/org/commonwl/view/workflow/WorkflowController.java

@@ -214,7 +214,7 @@ public ModelAndView getWorkflow(
   * @param branch The branch of the repository
   * @return The workflow view with the workflow as a model
   */
-  @GetMapping(value = "/workflows/**/*.git/{branch}/**")
+  @GetMapping(value = "/workflows/*/*.git/{branch}/**")


This needs to be well tested.

Now Spring Web doesn't allow any content after the /**. I found an issue or blog that suggested to test with /*/bla instead. Trying to get the tests and build to pass in order to verify it in the browser.

kinow · 2023-09-26T17:29:51Z

src/main/resources/logback.xml

@@ -9,7 +9,7 @@
            class="ch.qos.logback.core.ConsoleAppender">
    <layout class="ch.qos.logback.classic.PatternLayout">
      <Pattern>
-        %black(%d{ISO8601}) %highlight(%-5level) [%blue(%t)] %yellow(%C{1.}): %msg%n%throwable
+        %black(%d{ISO8601}) %highlight(%-5level) [%blue(%t)] %yellow(%C{1}): %msg%n%throwable


Was getting a NumberFormatException for 1., during the logback startup. This was the only place where I found the 1.. Changing it the build didn't fail in the same place, but will have to confirm what was the 1., and if the 1 alone will act the same way.

kinow · 2023-10-12T23:39:11Z

Fixed one broken test today, three more to go. Two I know the reason, but not the solution. The other we had during the migration mongo->postgres, so I just need to find the notes about how to debug that one (need to look at the query executed during the unit test...)

kinow · 2024-08-23T20:32:56Z

The last test failing is due to Hibernate/Postgres. At least the others were fixed (at least locally, waiting for GH Actions). Time to search for issues/SO's/etc now 😬

kinow · 2024-08-23T22:25:53Z

src/main/java/org/commonwl/view/workflow/QueuedWorkflowRepositoryImpl.java

+    //      mapping library we use, with what was the fix for our issue (ran
+    //      out of ideas, so started testing everything found online):
+    //      Use `new JsonType(GitDetails.class)`. That finally solved it.
+    //      Ref: https://github.com/common-workflow-language/cwlviewer/pull/568


The fix, finally ☝️

Works on my computer™, but pending tests with some workflows to confirm it's working.

kinow · 2024-08-23T22:33:06Z

Finally had some time to give it another try, and managed to get all tests passing. Still a couple of points pending, and I will try to do some manual tests using existing CWL workflows. But feel free to review or test it if you have time -- I will test it next time I have a chance, but at least we now have a working build with updated Spring Boot and dependencies 👋

mr-c

Really exciting, thank you @kinow !

src/test/java/org/commonwl/view/workflow/QueuedWorkflowRepositoryTest.java

… well, fixing tests.