Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycodegen: deal with anonymous types better #428

Merged
merged 2 commits into from
Sep 4, 2021
Merged

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Sep 4, 2021

The Python version of #423

Part of the fix for common-workflow-language/cwl-utils#71

@lgtm-com
Copy link

lgtm-com bot commented Sep 4, 2021

This pull request introduces 5 alerts when merging 440d845 into b2abeb5 - view on LGTM.com

new alerts:

  • 5 for Testing equality to None

@mr-c mr-c enabled auto-merge (rebase) September 4, 2021 13:08
@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #428 (b119fe9) into main (5fccc55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   79.49%   79.49%           
=======================================
  Files          18       18           
  Lines        3268     3268           
  Branches      880      880           
=======================================
  Hits         2598     2598           
  Misses        438      438           
  Partials      232      232           
Impacted Files Coverage Δ
schema_salad/python_codegen.py 95.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fccc55...b119fe9. Read the comment docs.

@mr-c mr-c disabled auto-merge September 4, 2021 13:40
@mr-c mr-c enabled auto-merge (squash) September 4, 2021 13:41
@mr-c mr-c disabled auto-merge September 4, 2021 13:41
@mr-c mr-c enabled auto-merge (squash) September 4, 2021 13:41
@mr-c mr-c merged commit 5c86585 into main Sep 4, 2021
@mr-c mr-c deleted the pycodegen_anon_types branch September 4, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant