Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check_exists cache negative results as well as positive ones #580

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tetron
Copy link
Member

@tetron tetron commented Aug 17, 2022

When loading a workflow with URL references that can't be resolved,
don't keep trying them over and over again.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #580 (e3271d5) into main (b39d984) will decrease coverage by 0.40%.
The diff coverage is 60.00%.

❗ Current head e3271d5 differs from pull request most recent head 6dbd430. Consider uploading reports for the commit 6dbd430 to get more accurate results

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   83.47%   83.08%   -0.40%     
==========================================
  Files          22       22              
  Lines        4502     4486      -16     
  Branches     1207     1239      +32     
==========================================
- Hits         3758     3727      -31     
- Misses        482      488       +6     
- Partials      262      271       +9     
Files Changed Coverage Δ
schema_salad/fetcher.py 63.47% <60.00%> (-1.66%) ⬇️

... and 19 files with indirect coverage changes

@tetron
Copy link
Member Author

tetron commented Jan 25, 2023

FWIW while I believe this is still a useful optimization, it turned out redundant failed lookups was not a major performance issue for the particular workflow I was working on.

When loading a workflow with URL references that can't be resolved,
don't keep trying them over and over again.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you take this out of draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants