Implement smarter is_subtype logic
#741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
adjust-is-subtype
branch
4 times, most recently
from
65e1611
to
559c3d7
Compare
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 83.47% 83.50% +0.02%
==========================================
Files 22 22
Lines 4502 4510 +8
Branches 1207 1212 +5
==========================================
+ Hits 3758 3766 +8
Misses 482 482
Partials 262 262
|
GlassOfWhiskey
force-pushed
the
adjust-is-subtype
branch
7 times, most recently
from
7e1963d
to
559c3d7
Compare
mr-c
force-pushed
the
adjust-is-subtype
branch
from
30a0654
to
8edaf93
Compare
Thic commit improves the `is_subtype` method to correctly handle a larger number of cases. In particular, it now deals with complex type definitions (i.e., those using `record` and `array` data structures) by correctly identifying when nested and recursive type definitions come with inheritance bounds.
mr-c
force-pushed
the
adjust-is-subtype
branch
3 times, most recently
from
3777960
to
fef7256
Compare
tetron
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
This LGTM
Notes from meeting:
- Should update Schema Salad specification v1.2 to indicate the old behavior (can only subtype simple classes) and describe the new behavior in Schema Salad spec v1.3
- SpecializeTo should be is_subtype of SpecializeFrom if it isn't checked already, maybe another thing to add for Schema Salad v1.3 spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thic commit improves the
is_subtypemethod to correctly handle a larger number of cases. In particular, it now deals with complex type definitions (i.e., those usingrecordandarraydata structures) by correctly identifying when nested and recursive type definitions come with inheritance bounds.