typescript changes to make ci run pass

commonknowledge · Sep 4, 2024 · 6a885df · 6a885df
1 parent 2aad3d5
commit 6a885df
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 12 deletions.
diff --git a/frontend/controllers/donation-controller.ts b/frontend/controllers/donation-controller.ts
@@ -2,20 +2,21 @@ import { Controller } from "@hotwired/stimulus";
 
 class DonationController extends Controller {
   static targets = ["input"];
+  inputTargets: any;
 
   setInputs(value: number) {
     // If the new value is one of the radios, select them
     // Else unselect all radios
     if (value) {
-      this.inputTargets.forEach((input) => {
+      this.inputTargets.forEach((input: { type: string; checked: boolean; value: string | number; }) => {
         if (input.type === "radio") {
-          input.checked = parseFloat(input.value) === value;
+          input.checked = parseFloat(input.value as string) === value;
         } else {
-          input.value = value;
+          input.value = String(value);
         }
       });
     } else {
-      this.inputTargets.forEach((input) => {
+      this.inputTargets.forEach((input: { type: string; checked: boolean; value: string; }) => {
         if (input.type === "radio") {
           input.checked = false;
         } else {
@@ -24,7 +25,6 @@ class DonationController extends Controller {
       });
     }
   }
-
   update(e: InputEvent) {
     let value = parseFloat((e.target as HTMLInputElement)?.value || "0") || 0;
     this.setInputs(value);

diff --git a/frontend/controllers/product-controller.ts b/frontend/controllers/product-controller.ts
@@ -58,10 +58,9 @@ export default class ShopifyBuyControllerBase extends Controller {
 }
   private LOCALSTORAGE_CHECKOUT_ID = "checkoutId";
 
-  get checkoutId() {
-    return window.localStorage
-      .getItem(this.LOCALSTORAGE_CHECKOUT_ID)
-      ?.toString();
+  get checkoutId(): string | number {
+    const id = window.localStorage.getItem(this.LOCALSTORAGE_CHECKOUT_ID);
+    return id ? id.toString() : ""; 
   }
 
   set checkoutId(id: string | number) {
@@ -81,7 +80,7 @@ export default class ShopifyBuyControllerBase extends Controller {
     });
 
     if (this.checkoutId) {
-      this.checkoutValue = await this.client.checkout.fetch(this.checkoutId);
+      this.checkoutValue = await this.client.checkout.fetch(this.checkoutId.toString());
     }
 
     let checkoutIsExpired = false;

diff --git a/frontend/main.ts b/frontend/main.ts
@@ -6,7 +6,13 @@ import "bootstrap";
 import initialiseSentry from "./sentry";
 import initialisePosthog from "./posthog";
 import { startApp } from "groundwork-django";
-const controllers = import.meta.glob("./controllers/*-controller.ts");
+import { ControllerConstructor } from "@hotwired/stimulus";
+
+const controllers = import.meta.glob("./controllers/*-controller.ts") as Record<
+  string,
+  () => Promise<{ default: ControllerConstructor }>
+>;
+
 Turbo.session.drive = false;
 
 initialisePosthog();
@@ -17,4 +23,4 @@ import { Application } from "@hotwired/stimulus";
 import ReadMore from "stimulus-read-more";
 const application = Application.start();
 application.register("read-more", ReadMore);
-application.debug = true;
+application.debug = true;