Skip to content

Commit

Permalink
Spacing changes in changelog.txt.
Browse files Browse the repository at this point in the history
  • Loading branch information
jgm committed Jan 29, 2024
1 parent 3c1fc35 commit 8fbf029
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,78 +39,57 @@
* CMake build changes (Saleem Abdulrasool).

+ Inline multiple variables in CMake, following CMake recommendations.

+ Simplify the version computation.

+ Remove the `CMARK_STATIC` and `CMARK_SHARED` options as one of the two
must be enabled always as the cmark executable depends on the library.
Instead of having a custom flag to discern between the
library type, use the native CMake option `BUILD_SHARED_LIBS`,
allowing the user to control which library to build. This matches
CMake recommendations to only build a single copy of the library.

+ Introduce an author warning for the use of `CMARK_SHARED` and
`CMARK_STATIC` to redirect the author of the dependent package to
`BUILD_SHARED_LIBS`.

+ Permit incremental linking on Windows. Although incremental linking
does introduce padding in the binary for incremental links, that
should not matter for release mode builds in theory as `/OPT:REF`
and `/OPT:ICF` will trigger full links, which is the default in
release mode.

+ Hoist the CMake module inclusion to the top level.

+ Minor tweaks for speeding up the configure phase.
Restructure the file layout to place the custom modules into the
`cmake/modules` directory that is the common layout for CMake based
projects.

+ Squelch C4232 warnings on MSVC builds.

+ Remove check for `__builtin_expect`. Use `__has_builtin` to check
at compile time if the feature is supported.
This macro is supported by both clang and GCC (as of 10).
In the case that the compiler in use is not new enough, we still
provide the fallback so that the code will compile but without the
additional hints for the branch probability. `config.h` has been
removed from the code base as it is no longer needed.

+ Remove `/TP` usage on MSVC and replace `CMARK_INLINE` with `inline`.
These were workarounds for pre-VS2015 compilers, which are no longer
supported.

+ Hoist the C visibility settings to top level

+ Clean up C4267 warnings on MSVC builds.

+ Remove some compiler compatibility checks that are no longer
needed because VS 2013 is no longer supported (#498).

+ Adjust the policy to silence warnings on MSVC builds
CMake 3.15+ remove `/W3` from the language flags under MSVC with
CMP0092. Set the policy to new to avoid the D9025 warning.

+ Reflow some text to match CMake documentation style

+ Use generator expression for path computation.

+ Use CMake to propagate `CMARK_STATIC_DEFINE`.

+ Clean up an obsoleted variable (NFC).

+ Hoist the policy settings. Policy settings may impact how
`project` functions. They should be set immediately after
`cmake_minimum_required` (which implicitly sets policies).
Use the `POLICY` check to see if a policy is defined rather
than using a version check.

+ Replace `CMARK_TESTS` with CMake sanctioned `BUILD_TESTING`.

+ Correct typo and adjust command invocation. Use the proper
generator expression for the python interpreter and adjust
a typo in the component name.

+ Add an upgrade path for newer CMake.
CMake 3.12 deprecated `FindPythonInterp`, and with CMake 3.27, were
obsoleted with CMP0148. Add a version check and switch to the new
Expand Down

0 comments on commit 8fbf029

Please sign in to comment.