-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify type of Markdown item as part of AST? #125
Comments
I'm not sure about this one. See the discussion at +++ Garen Torikian [May 12 16 14:53 ]:
|
To do this, we'd need to extend the API with something like Here's one potential issue I see: suppose we have an HTML -> CommonMark converter (I've written one of these using my lua bindings). If we add bullet types to the AST, then when we're building the AST to match the structure of the HTML document, we need to specify a bullet type of Perhaps this is just a minor inconvenience, since you could set this arbitrarily or leave it as its default value. I'd be receptive to a PR to add this feature, if you need it in github. |
This is not really a bug, but it's possible to send an input markdown consisting of lots of @ signs, and the recursion will cause memory explosion. The limit depends on the running environment, but there is no reason to accept arbitrarily long sequence of @, so let's just cut off at 1000.
I noticed that, given different types of lists, the AST renders the precise same way. (Example)
That is, given:
The AST lists
for both types of lists. I would hope that it had mentioned
asterisk
ordash
or something.@jgm Is there a reason for this? And if not, would you accept a contribution to fix that?
The text was updated successfully, but these errors were encountered: