-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser incorrectly reading strong/emph in paragraphs that contain links. #424
Labels
Comments
Curious. I can reproduce with the cmark command line tool:
And this is a regression -- I tried with an older version and didn't see this. |
Bisecting shows that this bug got introduced with commit ed0a4bf (fix for #389). |
nwellnhof
added a commit
to nwellnhof/cmark
that referenced
this issue
Sep 24, 2021
Fix a regression introduced with commit ed0a4bf. Also test the first delimiter against stack_bottom in process_emphasis. This happened to work with the old code and only led to a an unnecessary scan. Fixes commonmark#424.
nwellnhof
added a commit
to nwellnhof/cmark
that referenced
this issue
Sep 24, 2021
Fix a regression introduced with commit ed0a4bf. Also test the first delimiter against stack_bottom in process_emphasis. This happened to work with the old code and only resulted in an unnecessary scan. Fixes commonmark#424.
nwellnhof
added a commit
to nwellnhof/cmark
that referenced
this issue
Sep 24, 2021
Fix a regression introduced with commit ed0a4bf. Also test the first delimiter against stack_bottom in process_emphasis. This happened to work with the old code and only resulted in an unnecessary scan. Fixes commonmark#424.
nwellnhof
added a commit
to nwellnhof/cmark
that referenced
this issue
Sep 24, 2021
Fix a regression introduced with commit ed0a4bf. Also test the first delimiter against stack_bottom in process_emphasis. This happened to work with the old code and only resulted in an unnecessary scan. Fixes commonmark#424.
anticomputer
pushed a commit
to github/cmark-gfm
that referenced
this issue
Jan 23, 2023
Fix a regression introduced with commit ed0a4bf. Also test the first delimiter against stack_bottom in process_emphasis. This happened to work with the old code and only resulted in an unnecessary scan. Fixes commonmark#424.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following input produces an incorrect syntax tree:
This produces a tree:
I would expect text to have emphasis tags. It seems to only miss the last set of emphasis before the link. try
"*text* *text2* [link](google.com)"
Version:
"0.30.1"
Platform: Windows, Visual Studio 2017 v15.9.33
config.h:
The text was updated successfully, but these errors were encountered: