You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the tests are not compatible with CPython 3.5.0. With latest release 0.22.0 (and probably also master, since there's only one, unrelated commit since the latest release), four out of the six make test tests fail:
Most of the failures are due to the removed HTMLParseError in Python 3.5, and that one is easy to fix. See my proposed changes in #84 . After applying my patch, tests 3, 5, and 6 all pass, but there's still a non-trivial failure in html_normalization's doctest (log is here: https://gist.github.com/12b71e2ef22ef4b9d635):
Command: "/usr/local/bin/python3" "-m" "doctest" "/tmp/commonmark20150920-37576-vpuo15/cmark-0.22.0/test/normalize.py"Directory: /tmp/commonmark20150920-37576-vpuo15/cmark-0.22.0/build/testdir
"html_normalization" start time: Sep 20 16:36 PDT
Output:
----------------------------------------------------------
**********************************************************************
File "/tmp/commonmark20150920-37576-vpuo15/cmark-0.22.0/test/normalize.py", line 170, in normalize.normalize_html
Failed example:
normalize_html("∀&><"")
Expected:
'\u2200&><"'Got:
'∀&><"'
**********************************************************************
1 items had failures:
1 of 10 in normalize.normalize_html
***Test Failed*** 1 failures.
Looks like somehow the HTML entities have been decoded. I think it is related to the Python 3.5 change to HTMLParser: the convert_charrefs argument to __init__, introduced in Python 3.4, is now default to True. But I've tried passing convert_charrefs=False to __init__; that doesn't immediately fix the problem. I haven't got time to read through normalize.py, so perhaps someone else has to look at what's wrong with it.
The deprecated “strict” mode and argument of HTMLParser, HTMLParser.error(), and the HTMLParserError exception have been removed. (Contributed by Ezio Melotti in issue 15114.) The convert_charrefs argument of HTMLParser is now True by default. (Contributed by Berker Peksag in issue 21047.)
The text was updated successfully, but these errors were encountered:
Some of the tests are not compatible with CPython 3.5.0. With latest release 0.22.0 (and probably also master, since there's only one, unrelated commit since the latest release), four out of the six
make test
tests fail:A sample test log is here: https://gist.github.com/a13cfb20c900e16a8bf0.
Most of the failures are due to the removed
HTMLParseError
in Python 3.5, and that one is easy to fix. See my proposed changes in #84 . After applying my patch, tests 3, 5, and 6 all pass, but there's still a non-trivial failure inhtml_normalization
's doctest (log is here: https://gist.github.com/12b71e2ef22ef4b9d635):Looks like somehow the HTML entities have been decoded. I think it is related to the Python 3.5 change to
HTMLParser
: theconvert_charrefs
argument to__init__
, introduced in Python 3.4, is now default toTrue
. But I've tried passingconvert_charrefs=False
to__init__
; that doesn't immediately fix the problem. I haven't got time to read throughnormalize.py
, so perhaps someone else has to look at what's wrong with it.P.S. Quoting from https://docs.python.org/3.5/whatsnew/3.5.html:
The text was updated successfully, but these errors were encountered: