Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a .jar file, including your license, for distribution #253

Closed
JoePfeiffer opened this issue Feb 8, 2022 · 6 comments
Closed

Comments

@JoePfeiffer
Copy link

Is your feature request related to a problem? Please describe.
OpenRocket (https://github.com/openrocket/openrocket) has begun using your library, and we would like to properly cite your license. At the moment we're just linking to the license here on your project page; we'd also like to link to a copy embedded in your .jar

Describe the solution you'd like
As in the title: we'd very much appreciate if you could distribute a .jar with your license file, preferably at the top level.

Describe alternatives you've considered
We spent a little while trying to add it in ourselves, but eventually concluded simply having your library distributed with this would be of benefit both to us and to your other users.

Additional context
Add any other context about the feature request here.

@robinst
Copy link
Collaborator

robinst commented Feb 18, 2022

OpenRocket (https://github.com/openrocket/openrocket) has begun using your library

Cool project!

Yeah I agree that would be nice, just need to figure out the correct maven magic to do that. Help would be appreciated.

@JoePfeiffer
Copy link
Author

JoePfeiffer commented Feb 18, 2022

Yeah I agree that would be nice, just need to figure out the correct maven magic to do that. Help would be appreciated.

I wish I could! I know exactly 0 about maven.

@robinst
Copy link
Collaborator

robinst commented Feb 22, 2022

Oh it might just be creating a LICENSE.txt file in src/main/resources/META-INF (of every module), see https://stackoverflow.com/a/38836843. I'll try that.

@robinst
Copy link
Collaborator

robinst commented Feb 24, 2022

See PR: #253

robinst added a commit that referenced this issue Feb 24, 2022
@robinst
Copy link
Collaborator

robinst commented Feb 24, 2022

Ok, released 0.18.2 with the fix for this: https://github.com/commonmark/commonmark-java/blob/main/CHANGELOG.md#0182---2022-02-24

It should show up on Maven Central shortly.

@JoePfeiffer
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants